Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 4, 2025

Plan: Refactor TFM definitions in ReactiveUI.Avalonia

  • Explored repository structure and identified files to change
  • Update src/Directory.Build.props to add AvaloniaTargetFrameworks property with net10.0
  • Update src/ReactiveUI.Avalonia/ReactiveUI.Avalonia.csproj to use $(AvaloniaTargetFrameworks)
  • Update other Avalonia library projects to use $(AvaloniaTargetFrameworks) for consistency:
    • Splat.Avalonia.DryIoc
    • Splat.Avalonia.Autofac
    • Splat.Avalonia.Ninject
    • Splat.Avalonia.Microsoft.Extensions.DependencyInjection
  • Update test project to use appropriate TFM property
  • Verify build works correctly with refactored properties

Note: The problem statement specifically mentions updating only ReactiveUI.Avalonia.csproj, but for complete consistency I will update all Avalonia-related library projects to use the centralized property.

Original prompt

Refactor TFM definitions in ReactiveUI.Avalonia to align with splat and ReactiveUI

Description:

Currently, the ReactiveUI.Avalonia project hardcodes the Target Frameworks (TFMs) in its .csproj file. We want to refactor this to use the same pattern as splat and ReactiveUI, where TFMs are defined in the Directory.Build.props file for better consistency and easier maintenance across the repositories.

Instructions:

  1. Update src/Directory.Build.props:
    In reactiveui/reactiveui.avalonia/ReactiveUI.Avalonia-Add.NET10.0SupportAndMinorAPIImprovements/src/Directory.Build.props, replace the existing <BaseTargetFrameworks> property with a more specific one for Avalonia. This will allow us to manage the TFMs for all projects in this repository from a single location.

    Replace this:

    <BaseTargetFrameworks>netstandard2.0;net8.0;net9.0</BaseTargetFrameworks>

    With this:

    <AvaloniaTargetFrameworks>netstandard2.0;net8.0;net9.0;net10.0</AvaloniaTargetFrameworks>
  2. Update src/ReactiveUI.Avalonia/ReactiveUI.Avalonia.csproj:
    In reactiveui/reactiveui.avalonia/ReactiveUI.Avalonia-Add.NET10.0SupportAndMinorAPIImprovements/src/ReactiveUI.Avalonia/ReactiveUI.Avalonia.csproj, modify the <TargetFrameworks> element to reference the new property defined in Directory.Build.props.

    Replace this:

    <TargetFrameworks>netstandard2.0;net8.0;net9.0;net10.0</TargetFrameworks>

    With this:

    <TargetFrameworks>$(AvaloniaTargetFrameworks)</TargetFrameworks>

By making these changes, we will have a more consistent and maintainable build process that aligns with the standards set in our other repositories.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI requested a review from glennawatson October 4, 2025 03:11
@glennawatson glennawatson deleted the copilot/fix-2327577-1049224431-b6ada602-670b-4aaa-a86c-32ac4835a074 branch October 4, 2025 03:14
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants