Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 66.43% 59.86% -6.58%
==========================================
Files 12 16 +4
Lines 426 715 +289
Branches 76 103 +27
==========================================
+ Hits 283 428 +145
- Misses 121 263 +142
- Partials 22 24 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replaces internal Autofac, DryIoc, and Microsoft.Extensions.DependencyInjection dependency resolver implementations with the corresponding Splat.* packages. Updates AppBuilder extension methods to use new Splat APIs and removes obsolete code. Centralizes package version management and updates test projects and usages to reflect the new DI integration approach.
ChrisPulman
changed the title
Renamed all Splat.Avalonia.* projects, files, and namespaces to ReactiveUI.Avalonia.* equivalents. Enhanced DI mixins for Autofac, DryIoc, Ninject, and Microsoft.Extensions.DependencyInjection to support additional configuration and builder hooks. Updated solution and test project references to match new naming. Adjusted InternalsVisibleTo attributes for new test project names.
Introduces unit tests for Autofac and Ninject integration with Avalonia's ReactiveUI mixins, including null argument checks and builder return validation. Updates the test project to reference Autofac and Ninject projects with appropriate aliases.
Refactored DI container extension methods for Autofac, DryIoc, Microsoft.Extensions.DependencyInjection, and Ninject to use consistent namespaces and signatures. Updated the README with improved setup instructions, usage examples, and API documentation for all supported DI containers. Adjusted related tests to match new namespaces and method signatures.
Introduces new test classes covering AppBuilder extension methods for DI container integration (DryIoc, Microsoft.Extensions.DependencyInjection, and generic containers) and ReactiveUI view registration. These tests verify correct builder return values, null handling, and registration logic for the relevant extension methods.
There was a problem hiding this comment.
Pull Request Overview
This PR changes the version from 11.3.4 to 11.3.0 to match the release version of Avalonia. The PR also includes a significant reorganization of the codebase, removing many test files and transitioning from "Splat.Avalonia" naming to "ReactiveUI.Avalonia" naming.
- Updates version.json from 11.3.4 to 11.3.0 to match Avalonia
- Removes most test files and mocks from the Splat.Avalonia.Tests project
- Transitions project names from Splat.Avalonia.* to ReactiveUI.Avalonia.*
Reviewed Changes
Copilot reviewed 85 out of 89 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| version.json | Updates version from 11.3.4 to 11.3.0 |
| Various test files | Removed many test files from the Splat.Avalonia.Tests project |
| Project files | Renamed projects from Splat.Avalonia.* to ReactiveUI.Avalonia.* |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
glennawatson
approved these changes
Oct 5, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update
What is the new behavior?
Match release version of Avalonia
What might this PR break?
N/A
Please check if the PR fulfills these requirements
Other information: