Add AccessModifier support to ReactiveCommand

Introduces the AccessModifier property to the ReactiveCommand attribute, allowing generated command properties to specify their access level. Updates documentation, attribute definitions, generator logic, and test usage to support internal, protected, private, and other modifiers.

Author: ChrisPulman

README.md

@@ -37,12 +37,16 @@ ReactiveUI Source Generators automatically generate ReactiveUI objects to stream
 - `[ReactiveCommand(OutputScheduler = "RxApp.MainThreadScheduler")]` using a ReactiveUI Scheduler
 - `[ReactiveCommand(OutputScheduler = nameof(_isheduler))]` using a Scheduler defined in the class
 - `[ReactiveCommand][property: AttributeToAddToCommand]` with Attribute passthrough
+- `[ReactiveCommand(AccessModifier = PropertyAccessModifier.Internal)]` sets the access modifier of the generated command property
 - `[IViewFor(nameof(ViewModelName))]`
 - `[IViewFor<YourViewModelType>]`
 - `[IViewFor("YourNameSpace.YourGenericViewModel<int>")]` Generic
 - `[IViewFor<YourViewModelType>(RegistrationType = SplatRegistrationType.PerRequest)]` with Splat Registration Type for IViewFor registration.
 - `[IViewFor<YourViewModelType>(RegistrationType = SplatRegistrationType.LazySingleton)]` Generic with Splat Registration Type for IViewFor registration.
 - `[IViewFor<YourViewModelType>(RegistrationType = SplatRegistrationType.Constant)]` Generic with Splat Registration Type for IViewFor registration.
+- `[IViewFor<YourViewModelType>(ViewModelRegistrationType = SplatRegistrationType.PerRequest)]` Generic with Splat Registration Type for ViewModel registration.
+- `[IViewFor<YourViewModelType>(ViewModelRegistrationType = SplatRegistrationType.LazySingleton)]` Generic with Splat Registration Type for ViewModel registration.
+- `[IViewFor<YourViewModelType>(ViewModelRegistrationType = SplatRegistrationType.Constant)]` Generic with Splat Registration Type for ViewModel registration.
 - `[RoutedControlHost("YourNameSpace.CustomControl")]`
 - `[ViewModelControlHost("YourNameSpace.CustomControl")]`
 - `[BindableDerivedList]` Generates a derived list from a ReadOnlyObservableCollection backing field
@@ -544,6 +548,17 @@ public partial class MyReactiveClass
 }
 ```
 
+### Usage ReactiveCommand with AccessModifier
+```csharp
+using ReactiveUI.SourceGenerators;
+
+public partial class MyReactiveClass
+{
+    [ReactiveCommand(AccessModifier = PropertyAccessModifier.Internal)]
+    private void Execute() { }
+}
+```
+
 ## Usage IViewFor `[IViewFor(nameof(ViewModelName))]`
 
 ### IViewFor usage

src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs

@@ -437,7 +437,7 @@ protected virtual void Dispose(bool disposing)
     /// </summary>
     /// <param name="i">The i.</param>
     /// <returns>An Observable of int.</returns>
-    [ReactiveCommand]
+    [ReactiveCommand(AccessModifier = PropertyAccessModifier.Internal)]
     private IObservable<double?> Test8Observable(int i) => Observable.Return<double?>(i + 10.0);
 
     [ReactiveCommand]

src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs

@@ -42,6 +42,19 @@ internal enum AccessModifier
             Init,
         }
         
+        /// <summary>
+        /// Property Access Modifier.
+        /// </summary>
+        internal enum PropertyAccessModifier
+        {
+            Public,
+            Protected,
+            Internal,
+            Private,
+            InternalProtected,
+            PrivateProtected,
+        }
+        
         /// <summary>
         /// InheritanceModifier.
         /// </summary>
@@ -128,6 +141,14 @@ internal sealed class ReactiveCommandAttribute : global::System.Attribute
     /// The output scheduler.
     /// </value>
     public string? OutputScheduler { get; init; }
+
+    /// <summary>
+    /// Gets the AccessModifier of the ReactiveCommand property.
+    /// </summary>
+    /// <value>
+    /// The AccessModifier of the property.
+    /// </value>
+    public PropertyAccessModifier AccessModifier { get; init; }
 }
 #nullable restore
 #pragma warning restore

src/ReactiveUI.SourceGenerators.Roslyn/ReactiveCommand/Models/CommandInfo.cs

@@ -19,7 +19,8 @@ internal record CommandInfo(
     string? CanExecuteObservableName,
     CanExecuteTypeInfo? CanExecuteTypeInfo,
     string? OutputScheduler,
-    EquatableArray<string> ForwardedPropertyAttributes)
+    EquatableArray<string> ForwardedPropertyAttributes,
+    string AccessModifier)
 {
     private const string UnitTypeName = "global::System.Reactive.Unit";
 

src/ReactiveUI.SourceGenerators.Roslyn/ReactiveCommand/ReactiveCommandGenerator.Execute.cs

@@ -91,6 +91,20 @@ public partial class ReactiveCommandGenerator
 
         token.ThrowIfCancellationRequested();
 
+        // Get RegistrationType enum value from the attribute
+        attributeData.TryGetNamedArgument("AccessModifier", out int propertyAccessModifier);
+        var accessModifier = propertyAccessModifier switch
+        {
+            1 => "protected",
+            2 => "internal",
+            3 => "private",
+            4 => "protected internal",
+            5 => "private protected",
+            _ => "public",
+        };
+
+        token.ThrowIfCancellationRequested();
+
         var methodSyntax = (MethodDeclarationSyntax)context.TargetNode;
 
         context.GetForwardedAttributes(
@@ -118,7 +132,8 @@ public partial class ReactiveCommandGenerator
             canExecuteObservableName,
             canExecuteTypeInfo,
             outputScheduler,
-            forwardedPropertyAttributes);
+            forwardedPropertyAttributes,
+            accessModifier);
     }
 
     private static string GenerateSource(string containingTypeName, string containingNamespace, string containingClassVisibility, string containingType, CommandInfo[] commands)
@@ -202,7 +217,7 @@ private static string GetCommandSyntax(CommandInfo commandExtensionInfo)
 
         [global::System.CodeDom.Compiler.GeneratedCode("{{GeneratorName}}", "{{GeneratorVersion}}")]
         {{forwardedPropertyAttributesString}}
-        public {{RxCmd}}<{{inputType}}, {{outputType}}> {{commandName}} { get => {{initializer}} }
+        {{commandExtensionInfo.AccessModifier}} {{RxCmd}}<{{inputType}}, {{outputType}}> {{commandName}} { get => {{initializer}} }
 """;
 
         static string GenerateBasicCommand(CommandInfo commandExtensionInfo, string fieldName)