-
-
Notifications
You must be signed in to change notification settings - Fork 6
Fix For Reactive Property with Nested Classes #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for full license information. | ||
|
|
||
| using System.Collections.Generic; | ||
| using Microsoft.CodeAnalysis; | ||
| using ReactiveUI.SourceGenerators.Extensions; | ||
| using ReactiveUI.SourceGenerators.Helpers; | ||
|
|
@@ -15,7 +16,8 @@ internal sealed partial record TargetInfo( | |
| string TargetNamespace, | ||
| string TargetNamespaceWithNamespace, | ||
| string TargetVisibility, | ||
| string TargetType) | ||
| string TargetType, | ||
| TargetInfo? ParentInfo) | ||
| { | ||
| public static TargetInfo From(INamedTypeSymbol namedTypeSymbol) | ||
| { | ||
|
|
@@ -26,12 +28,64 @@ public static TargetInfo From(INamedTypeSymbol namedTypeSymbol) | |
| var targetAccessibility = namedTypeSymbol.GetAccessibilityString(); | ||
| var targetType = namedTypeSymbol.GetTypeString(); | ||
|
|
||
| var parentInfo = namedTypeSymbol.ContainingType is not null | ||
| ? From(namedTypeSymbol.ContainingType) | ||
| : null; | ||
|
|
||
| return new( | ||
| targetHintName, | ||
| targetName, | ||
| targetNamespace, | ||
| targetNameWithNamespace, | ||
| targetAccessibility, | ||
| targetType); | ||
| targetType, | ||
| parentInfo); | ||
| } | ||
|
|
||
| public static void GetParentClasses(ref List<string> parentClassDeclarations, TargetInfo? targetInfo) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. doesn't need to be ref does it |
||
| { | ||
| if (targetInfo is not null) | ||
| { | ||
| var parentClassDeclaration = $"{targetInfo.TargetVisibility} partial {targetInfo.TargetType} {targetInfo.TargetName}"; | ||
|
|
||
| // Add the parent class declaration if it does not exist in the list | ||
| if (!parentClassDeclarations.Contains(parentClassDeclaration)) | ||
| { | ||
| parentClassDeclarations.Add(parentClassDeclaration); | ||
| } | ||
|
|
||
| if (targetInfo.ParentInfo is not null) | ||
| { | ||
| // Recursively get the parent classes | ||
| GetParentClasses(ref parentClassDeclarations, targetInfo.ParentInfo); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public static string GenerateParentClassDeclarations(ref List<string> parentClassDeclarations) | ||
| { | ||
| // Reverse the list to get the parent classes in the correct order | ||
| parentClassDeclarations.Reverse(); | ||
|
|
||
| // Generate the parent class declarations | ||
| var parentClassDeclarationsString = string.Join("\n{\n", parentClassDeclarations); | ||
| if (!string.IsNullOrWhiteSpace(parentClassDeclarationsString)) | ||
| { | ||
| parentClassDeclarationsString += "\n{\n"; | ||
| } | ||
|
|
||
| return parentClassDeclarationsString; | ||
| } | ||
|
|
||
| public static string GenerateClosingBrackets(int numberOfBrackets) | ||
| { | ||
| var closingBrackets = new string('}', numberOfBrackets); | ||
| closingBrackets = closingBrackets.Replace("}", "}\n"); | ||
| if (!string.IsNullOrWhiteSpace(closingBrackets)) | ||
| { | ||
| closingBrackets = "\n" + closingBrackets; | ||
| } | ||
|
|
||
| return closingBrackets; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the offset is just caused by a
"""raw string literal, where the first line is not aligned with the ending quotes.