Fix for Nullable partial OAPH properties #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nullable partial properties with ObservableAsProperty are not updated with null value
glennawatson
approved these changes
Mar 16, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix for #197
What is the current behavior?
#197
What is the new behavior?
This pull request includes several changes to the
ReactiveUI.SourceGeneratorsproject, focusing on improving the handling of observable properties and enhancing the test view models. The most important changes include modifying property getters, adding new properties and attributes, and updating the test view models.Improvements to property getters:
src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromPartialProperty#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs: Modified the getter forTestPropertyto handle the case where_testPropertyHelperis null more explicitly.src/ReactiveUI.SourceGenerators.Roslyn/ObservableAsProperty/ObservableAsPropertyGenerator{FromObservable}.Execute.cs: Updated theGetPropertySyntaxmethod to account for properties from partial classes when determining the getter arrow expression.Enhancements to test view models:
src/ReactiveUI.SourceGenerators.Execute/TestClassOAPH_VM.cs: Added a new private field_testPropertyand initialized it in the constructor. Also, added a new observable propertyTestwith corresponding initialization logic. [1] [2] [3]src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs: Added a new propertyTestClassOAPH_VMto theTestViewModelclass to encapsulate an instance ofTestClassOAPH_VM.Documentation improvements:
src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs: Addedseealsoreferences to theTestClassdocumentation to improve clarity and maintainability.Nullable partial properties with ObservableAsProperty are not updated with null value
Adds check for partial properties to allow a null value after a value
What might this PR break?
Code is corrected for output, which may have lead to incorrect current value.
Please check if the PR fulfills these requirements
Other information: