Skip to content

Add ViewModelRegistrationType to IViewFor attribute #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisPulman merged 9 commits into from
Dec 8, 2025

Remove unnecessary null/empty check for vmType

2d43968
Select commit
Loading
Failed to load commit list.
Merged

Add ViewModelRegistrationType to IViewFor attribute #341

Remove unnecessary null/empty check for vmType
2d43968
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 8, 2025 in 0s

39.98% (-0.06%) compared to ecb5527

View this Pull Request on Codecov

39.98% (-0.06%) compared to ecb5527

Details

Codecov Report

❌ Patch coverage is 38.46154% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.98%. Comparing base (ecb5527) to head (2d43968).

Files with missing lines Patch % Lines
...ators.Roslyn/IViewFor/IViewForGenerator.Execute.cs 6.89% 23 Missing and 4 partials ⚠️
...UI.SourceGenerators.Roslyn/AttributeDefinitions.cs 85.71% 3 Missing ⚠️
...eGenerators.Roslyn/IViewFor/Models/IViewForInfo.cs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   40.04%   39.98%   -0.06%     
==========================================
  Files          61       61              
  Lines        3389     3429      +40     
  Branches      389      395       +6     
==========================================
+ Hits         1357     1371      +14     
- Misses       1926     1948      +22     
- Partials      106      110       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov