Skip to content

Conversation

@ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

update

What is the current behavior?

browserwasm uses TaskPoolScheduler.Default incorrectly

What is the new behavior?

Use WasmScheduler.Default for WebAssembly targets to handle lack of multithreading.

Update the csproj condition for browserwasm to use EndsWith for better compatibility.

What might this PR break?

N/A

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Use WasmScheduler.Default for WebAssembly targets to handle lack of multithreading, and update the csproj condition for browserwasm to use EndsWith for better compatibility.
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 5.43%. Comparing base (f22ab3c) to head (198bd61).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...veUI.Uno/Builder/UnoReactiveUIBuilderExtensions.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #268      +/-   ##
========================================
- Coverage   5.47%   5.43%   -0.04%     
========================================
  Files         16      16              
  Lines        712     717       +5     
  Branches     105     105              
========================================
  Hits          39      39              
- Misses       669     674       +5     
  Partials       4       4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisPulman ChrisPulman merged commit 1f80543 into main Sep 8, 2025
4 of 6 checks passed
@ChrisPulman ChrisPulman deleted the CP_AddBuilderWasmScheduler branch September 8, 2025 18:51
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants