fix: stop removing trailing single chars from query string #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Can we please get this or #2041 merged and deployed please, as it is quite broken for this use case. |
2 tasks
baynezy
changed the title
|
Does this also fix an issue with trailing slashes on the URI? e.g. https://github.com/reactiveui/refit/pull/ is getting modified to https://github.com/reactiveui/refit/pull which now fails on some sites?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This fixes #2044 and #2032
What is the current behavior?
Explained here #2044
What is the new behavior?
The trailing string logic for extracting parameters was overly aggressive.
What might this PR break?
I have run all existing tests and the one I added to show this bug and they all pass locally.
Please check if the PR fulfills these requirements
Docs did not need amending
Other information: