Skip to content

Conversation

@jsparkdev
Copy link
Contributor

  • /reference 경로의 사이드바에서 번역되지 않은 메뉴를 번역하였습니다.

Progress

@vercel
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 4:32am

@github-actions
Copy link

github-actions bot commented Sep 6, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[[...markdownPath]] 108.39 KB (🟡 +7 B) 212.59 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

},
{
"title": "Hooks",
"title": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Hooks'는 원래 번역하면 안되는 용어라 그대로 두어야 합니다.

(지금 wiki를 옮기는 과정 중에 있어서 해당 파트가 누락되었네요)

https://github.com/reactjs/ko.react.dev/wiki/Translate-Glossary -> 번역하면 안되는 용어가 적혀있는 legacy 링크입니다.

Copy link
Collaborator

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가로, [email protected] 사이드바에 Hooks으로 잘못 번역되어있는데,

이를 다시 영어 원문인 Hooks로 바꿔주시면 더 좋을 것 같습니다.👍

@jsparkdev
Copy link
Contributor Author

jsparkdev commented Sep 6, 2024

@lumirlumir 그렇다면 기존에 번역이 되어있던 이 문서를 가리키는 메뉴도 영어로 바꾸 는게 좋을까요?

아 코멘트가 달렸었군요! 그렇게 진행하겠습니다.

@lumirlumir
Copy link
Collaborator

네 감사합니다🙇‍♂️

@lumirlumir lumirlumir merged commit 782eb11 into reactjs:main Sep 6, 2024
@jsparkdev jsparkdev deleted the ref-sidebar branch September 6, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants