Skip to content

Conversation

lumirlumir
Copy link
Collaborator

@lumirlumir lumirlumir commented Sep 20, 2024

안녕하세요😊

PR의 Reviewers에 제 이름이 자동으로 추가되면 좋을 것 같아 CODEOWNERS에 이름을 추가하였습니다.

제 이름도 넣어주시면 감사하겠습니다!🙇‍♂️

그리고 @goofcode 라는 분이 존재하지 않는지 오류가 발생하여 해당 이름은 삭제 진행하였습니다.

image
image

Progress

@vercel
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 1:25pm

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 * CODEOWNERS*에는 maintainer들이 리스트업 되어잇어서 maintainer로 추가도 같이 제안해봅니다

@lumirlumir
Copy link
Collaborator Author

lumirlumir commented Sep 20, 2024

@gnujoow 혹시 maintainer도 제가 따로 코드상에 설정해야 하는 부분이 있을까요?🙇‍♂️

해당 내용도 같이 포함해서 commit을 추가해야 하나 해서 여쭙니다!


아, 혹시 기존 메인테이너분들이 따로 설정해주셔야 하는 걸까요?

@lumirlumir lumirlumir requested a review from gnujoow September 21, 2024 08:27
@hg-pyun
Copy link
Member

hg-pyun commented Sep 22, 2024

이전에 제가 설정해뒀습니다!

image

@hg-pyun hg-pyun merged commit ac57a11 into reactjs:main Sep 22, 2024
5 checks passed
@lumirlumir lumirlumir deleted the chore-codeowners branch September 22, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants