feat: introduction of editorconfig #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
lumirlumir
requested review from
MaxKim-J,
b9words,
eomttt,
gnujoow,
hg-pyun,
simsim0709,
taehwanno and
taggon
as code owners
hg-pyun
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요😊
#1068 PR과 같이 CRLF가 잘못 코드베이스에 들어가는 경우를 방지하기 위해, editorconfig를 도입하였습니다.
editorconfig에 다양한 옵션들이 많지만 우선 utf-8과 LF 강제 옵션만 추가하였습니다.
추가로, CI 환경과 pre-commit hook에서도 해당 내용을 검증하기 위해
editorconfig-checker라는 패키지를 설정한 후 관련 코드 세팅을 해주었습니다.현재 CI를 통과하지 못하는 것은 정상입니다. 이는 #1068 PR이 승인되어 CRLF가 모두 LF로 바뀌고, 해당 커밋이 현재 PR에 머지되어야만 통과할 수 있습니다.
Progress