Skip to content

Conversation

@lumirlumir
Copy link
Collaborator

안녕하세요😊

화면 좌측 하단에 종종 나오는 피드백 관련 UI가 애매하게 줄 바꿈이 되어 있는게 신경쓰여 수정하였습니다.

여러 사이즈의 반응형에서도 동일하게 잘 나오는 것을 확인하였습니다.

  • 수정 전

스크린샷 2024-10-04 201411

  • 수정 후

스크린샷 2024-10-04 201815
스크린샷 2024-10-05 001115

Progress

@vercel
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ko-react-dev 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 3:33pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Oct 4, 2024 3:33pm

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 104.3 KB (-6 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Collaborator

@eomttt eomttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요런 스타일은 원문 스타일이라서 가끔 싱크일 때마다 컨플릭 날 수도 있겠네요
#1078

@lumirlumir lumirlumir merged commit e9c3ba8 into reactjs:main Oct 8, 2024
5 checks passed
@lumirlumir lumirlumir deleted the design-ux-improvement-in-feedback-tsx branch October 8, 2024 02:17
@lumirlumir
Copy link
Collaborator Author

@eomttt

혹여 문제 생기면 다시 수정하도록 하겠습니다!

그리고 다른 UI 적인 부분 PR 들어온거 머지를 좀 했었는데(ex #1056), 관련해서 conflict난게 없는 것 보면 sync action이 해당 부분은 크게 신경쓰지 않는 것 같기도 합니다...!🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants