Changed the documentation of the subscribe argument to a more accurat… #6691
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @Tinttori! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
@Tinttori, I may be wrong so don't quote me on this, but I always thought "rendering" is the process of running the component functions, and React updates the DOM when the result of rendering is different. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
4 participants
The documentation of the subscribe argument in useSyncExternalStore was inaccurate. Now it says the following:
subscribe: A function that takes a single callback argument and subscribes it to the store. When the store changes, it should invoke the provided callback. This alerts React to potential changes in the store, but it will only cause the component to re-render if the snapshot, evaluated subsequently, has also changed. The subscribe function should return a function that removes the subscription when it's no longer needed. This helps prevent unnecessary re-renders and optimizes performance.