Skip to content

Conversation

kihyeoon
Copy link
Contributor

@kihyeoon kihyeoon commented Sep 1, 2024

This PR fixes a few typos in the documentation:

  1. Fixed missing ";" and corrected an extra ")" in the code examples in cache.md.
  2. Removed an unnecessary space before the closing </Suspense> tag in the Lazy guide.

Thanks for maintaining such great documentation!

Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2024 0:24am
react-dev ✅ Ready (Inspect) Visit Preview Sep 1, 2024 0:24am

Copy link

github-actions bot commented Sep 1, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@harish-sethuraman
Copy link
Collaborator

Thanks for sending a PR. but currently we aren't merging stylistic code changes.

@kihyeoon
Copy link
Contributor Author

kihyeoon commented Sep 2, 2024

@harish-sethuraman
Thank you for the feedback!
I just wanted to clarify that the issue in cache.md is actually a syntax error, not just a stylistic change.
The extra ")" in the code example would cause an error if the code were run.

Here's the problematic code:

function WeatherReport({record}) {
  const avgTemp = useMemo(() => calculateAvg(record)), record);
  // ...
}

Could we perhaps reconsider merging this change?

@harish-sethuraman
Copy link
Collaborator

Sorry my bad. Merging this 👍🏻 thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants