Replaced outdated placekitten calls with placeCats and loremflikcr URLS #7188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
messed this MR up. Going to close this PR and try again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
placeKittens no longer is working as intended after months of inconsistency. I have replaced the placeKittens calls with urls from loremflickr (replicating existing code for loop iterations) and that I have checked, along with placeCat calls (for individual, labelled calls.) I was unable to test as I wasn't comfortable installing an old yarn version, and it wouldn't build with the latest yarn version.
I feel that the changes are small enough that if this causes issues, a revert is simple. I doubt there will be any issues though.