Skip to content

Conversation

@GustavEikaas
Copy link

Hello!

I was reading the useEffect docs today and I got a bit curious about the useEffect for data fetching scenario.
The way I understand it, this is sort of a 101 section with super simple examples just to teach the users the basics.
However I was wondering if the example provided is sufficient? No loading states, no error states? On the off-chance anyone copies the example and uses it in a codebase it is missing some basic functionality.

I tried to make a change that doesnt overcomplicate the example but also provides the absolute minimum of what you would need should you decide to use a useEffect for data fetching.

Would love to hear your thoughts. I know there are more places further down in the docs that needs to be updated as a result of this but I would love to discuss the changes first. If they are acceptable I will update all places

@vercel
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 3:02pm
react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 3:02pm

@facebook-github-bot
Copy link
Collaborator

Hi @GustavEikaas!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@GustavEikaas GustavEikaas changed the title docs: draft first suggestion docs: useEffect for data fetching section Feb 12, 2025
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mattcarrollcode
Copy link
Contributor

@GustavEikaas Thank you for taking the time to open a PR and think through what might be missing from the docs!

However I was wondering if the example provided is sufficient?

By design, these usage examples are not sufficient. The reference docs are intended to be the minimum needed to describe an API so you can get started using it. The usage examples document common patterns and ways of using the API to help the reader better understand how to use the API. They are not meant to be a example to copy-paste into your app or represent best practices for the surrounding code that isn't directly related to using the API.

@GustavEikaas GustavEikaas deleted the docs/update-useEffect-data-fetching-section branch February 18, 2025 06:17
@GustavEikaas
Copy link
Author

I see.

Thanks for taking the time to review this pull request 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants