removing Provider as in React 19 Context can be used as a Provider #7654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
I was reading this section on https://react.dev/learn/passing-data-deeply-with-context and I thought the docs were broken somehow. It was confusing, because the text says "Wrap them with a context provider" yet the code snippet doesn't show a provider. Do you think it makes sense to reword the text somehow? Like
Or would it be valuable to show both the old and new syntax, since it will be deprecated in "future versions"? |
|
@locofocos The text 'context provider' looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://react.dev/blog/2024/12/05/react-19#context-as-a-provider
As per this blog post, In React 19 you can render
<Context>as a provider instead of<Context.Provider>and<Context.Provider>soon will be deprecated in future versions. So it is better to update the code on the page https://react.dev/learn/passing-data-deeply-with-context@gaearon Please review this PR. Thanks