Fix ESLint plugin version. #7768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added a sentence explaining that the rule needs to be explicitly enabled since it is not enabled by default (see https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/src/index.ts#L21-L24) and the rule's existence is not mentioned in the It would be great to add a strict config to the ESLint plugin that will enable and error on all rules. |
|
Thanks! Good call about rereleasing, I hadn't realized the caret range would pick up a deprecated package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0.0of the ESLint plugin was released accidentally as per (facebook/react#32982 (comment)). However, when using a^for the version range,6.0.0takes precedence over6.0.0-rc.1.This PR fixes the blog post to lock the version to
6.0.0-rc.1.If possible, please release
6.1.0-rc.1of the plugin instead to ensure6.0.0will not accidentally be installed.