Skip to content

Fix wrong documentation for effect events #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Fix wrong documentation for effect events #7800

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
132ef6c
Fix wrong documentation for effect events
gbhardwaj00 May 6, 2025
bb90c0c
Update src/content/learn/separating-events-from-effects.md
rickhanlonii May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/content/learn/separating-events-from-effects.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ function ChatRoom({ roomId, theme }) {
// ...
```
This solves the problem. Note that you had to *remove* `onConnected` from the list of your Effect's dependencies. **Effect Events are not reactive and must be omitted from dependencies.**
This solves the problem. Note that you had to *remove* `theme` from the list of your Effect's dependencies, because it's no longer used in the Effect. You also don't need to *add* `onConnected` to it, because **Effect Events are not reactive and must be omitted from dependencies.**
Verify that the new behavior works as you would expect:
Expand Down