-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Fix/tictactoe docs invalid file names #7969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/tictactoe docs invalid file names #7969
Conversation
Hi @mtayyabrawan! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
I have DoneI have signed Contributor License Agreement |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a comment on the file names, and can you revert the formatting changes?
… introductory section
@rickhanlonii take a look |
@rickhanlonii check again |
Ok so the last thing is that the image is pretty low quality. On large screen sizes it looks pixelated, and is half the size as the old image. Could you re-take it? |
@rickhanlonii By default in my system screenshots are low quality can i try with third party image enhancer |
You can try just zooming in on the browser |
ok |
@rickhanlonii Check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@rickhanlonii Thanks |
Fixes: #7926 - Tutorial: Tic-Tac-Toe incorrect description and images for where the source files reside
I have changed files names in docs from
index.js
,app.js
andstyles.css
tosrc/index.js
,src/app.js
andsrc/styles.css
that is according to the sandbox and also removed old wrong image of sandbox to the new one with current sandbox screenshotBefore it was like:
Now :