Skip to content

Conversation

mtayyabrawan
Copy link
Contributor

Fixes: #7926 - Tutorial: Tic-Tac-Toe incorrect description and images for where the source files reside

I have changed files names in docs from index.js, app.js and styles.css to src/index.js, src/app.js and src/styles.css that is according to the sandbox and also removed old wrong image of sandbox to the new one with current sandbox screenshot

Before it was like:

image

Now :

image

@meta-cla
Copy link

meta-cla bot commented Sep 4, 2025

Hi @mtayyabrawan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mtayyabrawan
Copy link
Contributor Author

@mtayyabrawan
Copy link
Contributor Author

Hi @mtayyabrawan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

I have Done

I have signed Contributor License Agreement

@meta-cla
Copy link

meta-cla bot commented Sep 4, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Sep 4, 2025
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a comment on the file names, and can you revert the formatting changes?

@mtayyabrawan
Copy link
Contributor Author

@rickhanlonii take a look

@mtayyabrawan
Copy link
Contributor Author

@rickhanlonii check again

@rickhanlonii
Copy link
Member

Ok so the last thing is that the image is pretty low quality. On large screen sizes it looks pixelated, and is half the size as the old image. Could you re-take it?

@mtayyabrawan
Copy link
Contributor Author

@rickhanlonii By default in my system screenshots are low quality can i try with third party image enhancer

@rickhanlonii
Copy link
Member

You can try just zooming in on the browser

@mtayyabrawan
Copy link
Contributor Author

ok

@mtayyabrawan
Copy link
Contributor Author

@rickhanlonii Check now

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rickhanlonii rickhanlonii merged commit d34c6a2 into reactjs:main Sep 4, 2025
6 checks passed
@mtayyabrawan
Copy link
Contributor Author

@rickhanlonii Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Tutorial: Tic-Tac-Toe incorrect description and images for where the source files reside

2 participants