Skip to content

Fix fragment link back button issue #8020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix fragment link back button issue #8020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/MDX/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ function Link({
</ExternalLink>
) : href.startsWith('#') ? (
// eslint-disable-next-line jsx-a11y/anchor-has-content
<a className={cn(classes, className)} href={href} {...props}>
<NextLink className={cn(classes, className)} href={href} {...props}>
{modifiedChildren}
</a>
</NextLink>
) : (
<NextLink href={href} className={cn(classes, className)} {...props}>
{modifiedChildren}
Expand Down
14 changes: 2 additions & 12 deletions src/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,8 @@ export default function MyApp({Component, pageProps}: AppProps) {
const router = useRouter();

useEffect(() => {
// Taken from StackOverflow. Trying to detect both Safari desktop and mobile.
const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
if (isSafari) {
// This is kind of a lie.
// We still rely on the manual Next.js scrollRestoration logic.
// However, we *also* don't want Safari grey screen during the back swipe gesture.
// Seems like it doesn't hurt to enable auto restore *and* Next.js logic at the same time.
history.scrollRestoration = 'auto';
} else {
// For other browsers, let Next.js set scrollRestoration to 'manual'.
// It seems to work better for Chrome and Firefox which don't animate the back swipe.
}
// Set scroll restoration to 'auto' for all browsers to fix fragment link back button issue
history.scrollRestoration = 'auto';
}, []);

useEffect(() => {
Expand Down