fix: remove sun.misc for OSGi imports on Java 11 or newer#4223
Open
rombert wants to merge 1 commit intoreactor:mainfrom
Open
fix: remove sun.misc for OSGi imports on Java 11 or newer#4223rombert wants to merge 1 commit intoreactor:mainfrom
rombert wants to merge 1 commit intoreactor:mainfrom
Conversation
Fixes reactor#3338 Signed-off-by: Robert Munteanu <robert@lmn.ro>
7d9227b to
bfc537f
Compare
Author
|
I've tested this on a vanilla distribution of Apache Felix and installed the prerequisites I've installed a SNAPSHOT build of the bundle, and when running Felix with Java 8 the bundle does not resolve Running When running on Java 21 the bundle is active and requirement for the sun.misc import is missing. Also, I tried making the change more gradle-idiomatic but I did not really find a way to do so; it seems that the bnd multi-release jar functionality does not allow tweaking the manifest. Happy to take feedback if anyone sees a different way of removing the jars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer require
sun.miscin OSGi environments running Java 11 or newer.The
sun.miscrequirement is only mandatory for Java 8 but this was not reflected in the OSGi requirements,leading to additional friction when deploying the bundle.
This change post-processes all multi-version manifests to no longer require
sun.misc.Fixes #3338