fixed waiting for maxDelayRebalance with AckMode.EXACTLY_ONCE during rebalancing #371 #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damn1kk Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Don't increment uncommitted messages in CommitBatch for AckMode.ExactlyOnce. Increasing the number of uncommitted messages in CommitBatch causes an infinite loop during rebalancing because they never decrease. Fixes reactor#371.
damn1kk
force-pushed
the
fix-long-rebalance-for-exactly-once
branch
from
b25fe21 to
a8c7b83
Compare
|
@damn1kk Thank you for signing the Contributor License Agreement! |
Author
|
@violetagg , @chemicL , @artembilan can someone of you please have a look ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #371
Fixed waiting for maxDelayRebalance with AckMode.EXACTLY_ONCE during rebalancing.
Don't increment uncommitted messages in CommitBatch for AckMode.ExactlyOnce.
Increasing the number of uncommitted messages in CommitBatch causes an infinite loop during rebalancing because they never decrease for AckMode.ExactlyOnce.