Skip to content

Conversation

@grimmy
Copy link
Contributor

@grimmy grimmy commented Jul 18, 2025

This was tested against a clean install using
ReactOS-0.4.15-release-1-gdbb43bbaeb2-x86-iso

@julenuri julenuri self-requested a review July 18, 2025 15:31
Copy link
Collaborator

@julenuri julenuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check also if you can attach a screenshot of it working. Thanks, I like your PR. :D

URLDownload = https://jztkft.dl.sourceforge.net/project/pidgin/Pidgin/2.14.1/pidgin-2.14.1.exe
SHA1 = 6cabba4a6afebd7b9c5ce74fa12c655cafd5b445
SizeBytes = 8697184
URLDownload = https://sourceforge.net/projects/pidgin/files/Pidgin/2.14.14/pidgin-2.14.14-offline.exe/download
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good option. Have you tested rapps is able to download a link with the "/download" at the end of the link? Check it.

Copy link
Contributor Author

@grimmy grimmy Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I updated the file on my machine and downloaded via the package manager directly. Whoops, looks like the SaveAs didn't make it to the pull request. Let me fix that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derp, I didn't scroll all the way down. The /download works because the SaveAs (the line below these comments) sets the filename.

@grimmy
Copy link
Contributor Author

grimmy commented Jul 18, 2025

Check also if you can attach a screenshot of it working. Thanks, I like your PR. :D

Do you want the screenshot here or is there a way to put it in the file?

@grimmy
Copy link
Contributor Author

grimmy commented Jul 18, 2025

Check also if you can attach a screenshot of it working. Thanks, I like your PR. :D

Do you want the screenshot here or is there a way to put it in the file?

nm, I see I can put it it in the file.

This was tested against a clean install using
ReactOS-0.4.15-release-1-gdbb43bbaeb2-x86-iso
@grimmy
Copy link
Contributor Author

grimmy commented Jul 18, 2025

Alright here and update with the screen shot and a screenshot of it working ;)
reactos-pidgin-screenshot-rapp

@katahiromz katahiromz changed the title Update to Pidgin 2.14.14 [RAPPS-DB] Update to Pidgin 2.14.14 Jul 18, 2025
@julenuri julenuri merged commit 436605e into reactos:master Jul 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants