[RAPPS-DB] Add missing icons & strings for the Music category#337
[RAPPS-DB] Add missing icons & strings for the Music category#337julenuri merged 31 commits intoreactos:masterfrom
Conversation
ethemja
changed the title
|
and I also recommend removing the license sections from all Turkish descriptions; it looks more legible if they are removed 
|
|
@julenuri for review |
|
Bring me 24 hours, I will try to review asap. |
julenuri
left a comment
julenuri
left a comment
There was a problem hiding this comment.
Some minor changes and I will pass your PR :D
mpxplay.txt
Outdated
| License = GPL | ||
| License = Proprietary | ||
| LicenseType = 2 |
There was a problem hiding this comment.
MPXPlay is open source according to the official website, but you need the permission from the original author to edit it. Sourcecode downloadable in: https://sourceforge.net/projects/mpxplay/files/Mpxplay/Mpxplay-MMC%20v3.2x/ And the code says:
This file is part of the Mpxplay - audio player. * //* The source code of Mpxplay is (C) copyright 1998-2025 by PDSoft (Attila Padar) http://mpxplay.sourceforge.net email: mpxplay@hotmail.com **************** //* This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Please contact with the author (with me) if you want to use or modify this source.
podcasteasy.txt
Outdated
| License = Public domain | ||
| License = Proprietary | ||
| LicenseType = 2 |
There was a problem hiding this comment.
According to the original official Github, the license is public domain. I wouldn't change that.
|
is the PR now acceptable? @julenuri |
|
Okkay for me. |
2 participants
What did I do?
I added the foobar2000, podcasteasy, and twsynth icons, made a general license fix for the music category, and corrected missing and incorrect lines.