Skip to content

Conversation

@nhedger
Copy link
Contributor

@nhedger nhedger commented Jun 20, 2022

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thank you!

Can you apply/squash this minor suggestion? Once this is in, we should also apply the same changes to the 3.x and 2.x branches 👍

@clue clue added this to the v4.0.0 milestone Jun 20, 2022
@clue clue requested a review from WyriHaximus June 20, 2022 14:53
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thanks for the quick update, changes LGTM! 👍

@WyriHaximus WyriHaximus merged commit 8f4251c into reactphp:4.x Jun 24, 2022
@nhedger nhedger deleted the chore/remove-leading-dollar branch June 24, 2022 09:57
@clue
Copy link
Member

clue commented Jun 27, 2022

@nhedger Glad this has been merged! Can you also apply the same changes to the 3.x and 2.x branches? 👍

@nhedger
Copy link
Contributor Author

nhedger commented Jun 28, 2022

@clue, see #52 and #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants