Skip to content

Commit 1c46b3b

Browse files
authored
Merge pull request #98 from clue-labs/tests
Skip failing tests on bugged versions (PHP 8.1.8)
2 parents 8280258 + 5d33ec9 commit 1c46b3b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/AbstractProcessTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ public function testDetectsClosingStdoutWithoutHavingToWaitForExit()
643643
$this->markTestSkipped('Process pipes not supported on Windows');
644644
}
645645

646-
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
646+
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
647647
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
648648
}
649649

@@ -673,7 +673,7 @@ public function testDetectsClosingStdoutWithoutHavingToWaitForExit()
673673
*/
674674
public function testDetectsClosingStdoutSocketWithoutHavingToWaitForExit()
675675
{
676-
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
676+
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
677677
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
678678
}
679679

@@ -711,7 +711,7 @@ public function testKeepsRunningEvenWhenAllStdioPipesHaveBeenClosed()
711711
$this->markTestSkipped('Process pipes not supported on Windows');
712712
}
713713

714-
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
714+
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
715715
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
716716
}
717717

@@ -750,7 +750,7 @@ public function testKeepsRunningEvenWhenAllStdioPipesHaveBeenClosed()
750750
*/
751751
public function testKeepsRunningEvenWhenAllStdioSocketsHaveBeenClosed()
752752
{
753-
if (PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
753+
if (PHP_VERSION_ID === 80108 || PHP_VERSION_ID === 80107 || PHP_VERSION_ID === 80020) {
754754
$this->markTestSkipped('Skip bugged PHP version: https://github.com/php/php-src/issues/8827');
755755
}
756756

0 commit comments

Comments
 (0)