Skip to content

Conversation

WyriHaximus
Copy link
Member

This ports #237 from 3.x to 1.x.

In a recent Ubuntu 24.04 runner update something changed that makes PHP code seemingly more performant. In #236 this issue is shown to have something to do with 24.04 because without code changes it works on 22.04. However, that doesn't fix the underlying issue.

While I'm not sure what changed, by increasing these two numbers by 10 folding them we're back at passing tests.

This ports reactphp#237 from 3.x to 1.x.

In a recent Ubuntu 24.04 runner update something changed that makes PHP
code seemingly more performant. In reactphp#236 this issue is shown to have
something to do with 24.04 because without code changes it works on 22.04. However, that doesn't fix the underlying issue.

While I'm not sure what changed, by increasing these two numbers by 10
folding them we're back at passing tests.
@WyriHaximus WyriHaximus added this to the v1.14.0 milestone Aug 26, 2025
@WyriHaximus WyriHaximus requested a review from clue August 26, 2025 07:25
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request Aug 26, 2025
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Changes LGTM, thanks for cherry-picking!

For context: We discussed in person the build breaks on macOS only, this is already addressed in #239 which will only need a rebase once this is merged.

@clue clue merged commit 30c355a into reactphp:1.x Oct 13, 2025
14 of 15 checks passed
@WyriHaximus WyriHaximus deleted the 1.x-increase-query-count-in-excessive-tcp-query-tests branch October 13, 2025 11:10
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request Oct 13, 2025
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants