feat: keep examples, and quotes #2622
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If it was just about me, I would drop the idea. Lets keep the issue open for some time, maybe something might come out from there. /cc @lasconic if you have a opinion I would be glad to read it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2439.
I did not finished either FR or EN since I am doubting we want this. FR and EN dictionary sizes will explode, and more importantly, definitions will be tough to read. I am thinking of the Kindle, with small area for the dictionary, it will become a mess.
Another issue, for ZH, is that quotes are partly badly displayed on Kobo.
All in all, it seems that other locales might benefit of this, but I'm not sure about EN, FR, RU and ZH.