Skip to content

Conversation

@martin-mfg
Copy link
Contributor

  • permissions are specified under jobs -> build, there's no need to mention them at root level too
  • currently the "v1" tag still points to the same commit as "v1.0.0". I think either the readme sample should be updated to contain the new "V1.1.0" tag (notice the uppercase "V"), or the "v1" tag should be moved.
  • just FYI: In the logs there is still a warning "(node:2116) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.". This seems to be an issue in setup-node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant