feat(oas-to-har): retain null values in array#998
Merged
erunion merged 4 commits intoreadmeio:mainfrom Oct 6, 2025
Merged
Conversation
erunion
reviewed
Sep 10, 2025
Member
There was a problem hiding this comment.
why are we vendoring and forking remove-undefined-objects in here instead of adding a new option to that library for preserving empty arrays? thats what @mjcuva and i talked about out what i thought needed to happen for this ticket
kanadgupta
suggested changes
Sep 13, 2025
Contributor
kanadgupta
left a comment
There was a problem hiding this comment.
can you use the latest release of remove-undefined-objects@7.0.0 here?
erunion
approved these changes
Oct 6, 2025
kanadgupta
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This PR is part of the work for the readme ticket RM-9906 Not displaying null values in an array and should get merged ONLY after the corresponding PR changes in the
remove-undefined-objectsrepo is shippedThe aim of the ticket is we want user-added null values in arrays to be visible in requests.
This requires adjustments in the oas-to-har package, with two separate causes of why the nulls in array are being dropped
Updated stripEmptyObjects to stop removing null values in arrays, while still removing undefined, empty objects, and empty arrays.
TODO Before Merging:
🧬 QA & Testing