Merged
Conversation
kanadgupta
commented
Jul 11, 2025
| "@commitlint/config-conventional": "^19.0.3", | ||
| "@oclif/test": "^4.1.0", | ||
| "@readme/better-ajv-errors": "^2.3.2", | ||
| "@readme/eslint-config": "^14.7.2", |
Contributor
Author
There was a problem hiding this comment.
as part of this PR, i removed our eslint config and inlined our prettier setup so we're officially ✨ free of deprecation warnings ✨
This comment was marked as resolved.
This comment was marked as resolved.
erunion
reviewed
Jul 14, 2025
erunion
approved these changes
Jul 14, 2025
Contributor
Author
|
🎉 This PR is included in version 10.5.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
Author
|
🎉 This PR is included in version 10.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
@oclif/coremessed with some of the bespoke logic in ourprerunhook. i was initially looking into it with the intent of filing a bug in that repo, but i'm pretty sure what we were doing there was going against the grain of how oclif works, so i ended up refactoring it, which ended up cleaning up the logic and tests a bunch in the process? you can see that work in 109b6c9@readme/eslint-configonce and for all (and copies/inlines our prettier config)thiscontext so we can reduce our reliance on our bespoke debuggerbefore:
after: