Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/ethicalads.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/ethicalads.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,7 @@ if (check_dependencies()) {
wait_dom.then(() => {
load_placements()
.then((placements) => {
resolve(placements);
resolve(placements.filter((p) => p != null));
})
.catch((err) => {
resolve([]);
Expand Down
2 changes: 1 addition & 1 deletion tests/missing-placement.test.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
describe("EthicalAds library", () => {
it("skips manual placements", async () => {
const placements = await wait;
expect(placements).to.be.an("array").that.includes(null);
expect(placements.length).equals(0);
});
it("can force load manual placements", async () => {
const placements = await load_placements(true);
Expand Down