Add title to the status icon #654
Conversation
I was confused what they mean, and this will help users understand. This seems to fail linting and when linted does a crazy single line string, which I don't think we want?
| {% else %} | ||
| {% trans "Build in progress" %} | ||
| {% endif %}"> | ||
| </i> |
There was a problem hiding this comment.
To avoid a multiline attribute, this should all be wrapped with spaceless similar to the attributes above this.
There was a problem hiding this comment.
I'm not sure spaceless is working..
There was a problem hiding this comment.
Spaceless only removes spaces between HTML tags, not inside of text content: https://docs.djangoproject.com/en/5.2/ref/templates/builtins/#spaceless
Only space between tags is removed – not space between tags and text.
There was a problem hiding this comment.
Bah yeah you're right. This is going to be another case of fighting with Django templates to do something really basic. There might be a way to use {% filter cut:"" %} but this almost certainly requires a small, custom filter.
These blocks are all trying to do the same thing, so should all match.
|
The styling on these seem a bit odd.. is there some way to make it styled nicer? 
|
Adding a title to an element is a native browser thing, FUI doesn't alter the styling of these at all. The title popup isn't styled weird, it's just displaying all of the whitespace included in the attribute. It might be possible to control whitespace with CSS but I feel that would be getting pretty deep in the weeds for a fix. I regret not preempting a migration to Jinja templates, it would have solved a lot of Django template headaches. |
2 participants
I was confused what they mean,
and this will help users understand.
This seems to fail linting and when linted does a crazy single line string,
which I don't think we want?