test strip to barebones for tests

Author: silentfatez

readthedocs/builds/models.py

@@ -540,12 +540,6 @@ def get_conf_py_path(self):
         conf_py_path = os.path.relpath(conf_py_path, checkout_prefix)
         return conf_py_path
 
-    def get_mkdocs_yml_path(self):
-        mkdocs_yml_path = self.project.yaml_dir(self.slug)
-        checkout_prefix = self.project.checkout_path(self.slug)
-        mkdocs_yml_path = os.path.relpath(mkdocs_yml_path, checkout_prefix)
-        return mkdocs_yml_path
-
     def get_storage_paths(self, version_slug=None):
         """
         Return a list of all build artifact storage paths for this version.

readthedocs/projects/models.py

@@ -35,7 +35,6 @@
 from readthedocs.core.resolver import Resolver
 from readthedocs.core.utils import extract_valid_attributes_for_model, slugify
 from readthedocs.core.utils.url import unsafe_join_url_path
-from readthedocs.doc_builder.exceptions import MkDocsYAMLParseError
 from readthedocs.domains.querysets import DomainQueryset
 from readthedocs.domains.validators import check_domains_limit
 from readthedocs.notifications.models import Notification as NewNotification
@@ -970,26 +969,11 @@ def conf_file(self, version=LATEST):
 
         raise ProjectConfigurationError(ProjectConfigurationError.NOT_FOUND)
 
-    def yaml_file(self, version=LATEST):
-        """Find a mkdocs ``mkdocs.yml`` file in the project checkout."""
-        files = self.find("mkdocs.yml", version)
-        if not files:
-            files = self.full_find("mkdocs.yml", version)
-        if len(files) == 1:
-            return files[0]
-        # TODO: Handle for multiple Files
-        raise MkDocsYAMLParseError(MkDocsYAMLParseError.NOT_FOUND)
-
     def conf_dir(self, version=LATEST):
         conf_file = self.conf_file(version)
         if conf_file:
             return os.path.dirname(conf_file)
 
-    def yaml_dir(self, version=LATEST):
-        yaml_file = self.yaml_file(version)
-        if yaml_file:
-            return os.path.dirname(yaml_file)
-
     @property
     def has_good_build(self):
         # Check if there is `_good_build` annotation in the Queryset.

readthedocs/rtd_tests/tests/test_doc_builder.py

@@ -118,29 +118,19 @@ def test_multiple_conf_py(
             with override_settings(DOCROOT=tmp_docs_dir):
                 base_sphinx.show_conf()
 
-    @patch("readthedocs.doc_builder.backends.mkdocs.BaseMkdocs.docs_dir")
     @patch("readthedocs.doc_builder.backends.mkdocs.BaseMkdocs.run")
-    @patch("readthedocs.builds.models.Version.get_mkdocs_yml_path")
-    @patch("readthedocs.projects.models.Project.checkout_path")
     @patch("readthedocs.doc_builder.python_environments.load_yaml_config")
     def test_project_without_mkdocs_yaml(
         self,
         load_yaml_config,
-        checkout_path,
-        get_mkdocs_yml_path,
         _,
-        docs_dir,
     ):
         """
         Test for a project without ``mkdocs.yaml`` file.
 
         When this happen, the ``get_mkdocs_yml_path`` raises a
         ``MkDocsYAMLParseError`` which is captured by our own code.
         """
-        tmp_dir = tempfile.mkdtemp()
-        checkout_path.return_value = tmp_dir
-        docs_dir.return_value = tmp_dir
-        get_mkdocs_yml_path.side_effect = MkDocsYAMLParseError
         python_env = Virtualenv(
             version=self.version,
             build_env=self.build_env,