Skip to content

Build: auto-disable ACKS_LATE for long builds #12393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025
Merged

Build: auto-disable ACKS_LATE for long builds #12393

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e5f3f0
Build: auto-disable `ACKS_LATE` for long builds
humitos Aug 12, 2025
c02ab50
Check for `None`
humitos Aug 13, 2025
bdb34f6
Always use no acks late when build time is bigger than default
humitos Aug 13, 2025
f4fd39a
Feedback from review
humitos Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion readthedocs/core/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,11 @@ def prepare_build(
# At 1h exactly, the task is grabbed by another worker and re-executed,
# even while it's still running on the original worker.
# https://github.com/readthedocs/readthedocs.org/issues/12317
if project.has_feature(Feature.BUILD_NO_ACKS_LATE):
if (
project.has_feature(Feature.BUILD_NO_ACKS_LATE)
or project.container_time_limit
and project.container_time_limit > settings.BUILD_TIME_LIMIT
):
log.info("Disabling ACKS_LATE for this particular build.")
options["acks_late"] = False

Expand Down