Skip to content

Build: use FINISHED state for inactive builds #12426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Build: use FINISHED state for inactive builds #12426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readthedocs/projects/tasks/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from django.utils import timezone

from readthedocs.builds.constants import BUILD_FINAL_STATES
from readthedocs.builds.constants import BUILD_STATE_CANCELLED
from readthedocs.builds.constants import BUILD_STATE_FINISHED
from readthedocs.builds.constants import EXTERNAL
from readthedocs.builds.models import Build
from readthedocs.builds.tasks import send_build_status
Expand Down Expand Up @@ -127,7 +127,7 @@ def finish_unhealthy_builds():
builds = Build.objects.filter(query)[:50]
for build in builds:
build.success = False
build.state = BUILD_STATE_CANCELLED
build.state = BUILD_STATE_FINISHED
build.save()

# Tell Celery to cancel this task in case it's in a zombie state.
Expand Down