Add GITHUB_APP_NAME to context processor #12511
Merged
+2
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for readthedocs/ext-theme#655, which otherwise I need to override the Allauth views for, and this seems useful in other places if we want to keep linking it.
humitos
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
I was sure that we were already passing this somehow.
I found we are using it in https://github.com/readthedocs/ext-theme/blob/main/readthedocsext/theme/templates/projects/partials/project_create_automatic.html#L108 and passing it in the context at https://github.com/readthedocs/readthedocs.org/blob/main/readthedocs/projects/views/private.py#L462
We can remove it from views/private.py now that we are including in the global context.
|
@stsewd Do you know if this is used? readthedocs.org/readthedocs/profiles/views.py Line 351 in ec3bf45 I don't see it in any templates |
|
I think it's safe to remove it from there as well. I don't see it anywhere. |
|
Should be safe to remove, yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for readthedocs/ext-theme#655,
which otherwise I need to override the Allauth views for,
and this seems useful in other places if we want to keep linking it.