-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Migrate Celery settings to new format with CELERY_ namespace #12622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: humitos <[email protected]>
humitos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after answering my question.
Also, we need to check the settings in https://github.com/readthedocs/readthedocs-ops and https://github.com/readthedocs/readthedocs-corporate-ops and migrate them as well. @copilot can you do that?
I can only work on the current repository (readthedocs.org). I don't have access to the readthedocs-ops and readthedocs-corporate-ops repositories. Someone with access to those repos will need to migrate the settings there using the same naming conventions from this PR. |
I checked in -ops repositories and opened:
|
|
We can merge this after today's deploy, so we have a full week to test it locally just in case. |
|
Well, we didn't merge this for this deploy, but that's fine. We don't want to deal with Celery issues during Xmas 😄 . I add this PR to one of the first sprints of 2026. |
Celery 6.x will drop support for deprecated settings and require explicit
CELERYnamespace prefix. This migrates all settings to the new lowercase format.Changes
worker.py: Add
namespace="CELERY"toconfig_from_object():Settings renamed (base.py, test.py, docker_compose.py):
CELERY_ALWAYS_EAGER→CELERY_TASK_ALWAYS_EAGERCELERYD_TASK_TIME_LIMIT→CELERY_TASK_TIME_LIMITCELERYD_HIJACK_ROOT_LOGGER→CELERY_WORKER_HIJACK_ROOT_LOGGERCELERYD_PREFETCH_MULTIPLIER→CELERY_WORKER_PREFETCH_MULTIPLIERCELERY_ACKS_LATE→CELERY_TASK_ACKS_LATECELERY_IGNORE_RESULT→CELERY_TASK_IGNORE_RESULTCELERY_CREATE_MISSING_QUEUES→CELERY_TASK_CREATE_MISSING_QUEUESCELERY_DEFAULT_QUEUE→CELERY_TASK_DEFAULT_QUEUECELERYBEAT_SCHEDULER→CELERY_BEAT_SCHEDULERCELERYBEAT_SCHEDULE→CELERY_BEAT_SCHEDULEBROKER_URL→CELERY_BROKER_URLBROKER_TRANSPORT_OPTIONS→CELERY_BROKER_TRANSPORT_OPTIONSCode references updated:
core/utils/tasks/public.py:settings.CELERY_TASK_ALWAYS_EAGERcore/tasks.py:settings.CELERY_BROKER_URLRefs: https://docs.celeryq.dev/en/stable/userguide/configuration.html#new-lowercase-settings
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.