Skip to content

Conversation

@Blendify
Copy link
Member

@Blendify Blendify commented Dec 1, 2020

Instead of using our own template uses sphinx's basic search.html instead.
This change is almost identical except for the new search page includes
a search box. As a result, the search box is hidden on the search page.

image

Close #998

Instead of using our own template uses sphinx's basic search.html 
instead.
This change is almost identical except for the new search page includes 
a search box. As a result, the search box is hidden on the search page.
@Blendify Blendify requested a review from a team December 1, 2020 21:02
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one thing, we are missing the display_vcs_links var that is used here

{% set display_vcs_links = display_vcs_links if display_vcs_links is defined else True %}

I think we can just check if pagename is different from search here

{% if hasdoc(pagename) and display_vcs_links %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search page empty

4 participants