Skip to content

Conversation

@Blendify
Copy link
Member

I moved breadcrumbs to the rest of the layout as it seems to belong
better here.
I also went through and removed some unused rules.

These changes can be split up into two patchs if needed.

I moved breadcrumbs to the rest of the layout as it seems to belong 
better here.
I also went through and removed some unused rules.

These changes can be split up into two patchs if needed.
Comment on lines -13 to -23
code
padding: 5px
border: none
background: none
&.literal
color: $text-color
.wy-breadcrumbs-extra
margin-bottom: 0
color: $text-light
font-size: 80%
display: inline-block
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was also removed, the rest of this file was only moved.

@Blendify Blendify requested review from a team, agjohnson, ericholscher and stsewd February 26, 2021 07:17
@Blendify Blendify added this to the 1.0.0 milestone Mar 11, 2021
@Blendify Blendify marked this pull request as draft March 11, 2021 23:55
@agjohnson agjohnson modified the milestones: 1.0, 1.1 Mar 17, 2021
@benjaoming benjaoming modified the milestones: 1.1, 2.0 Aug 27, 2022
@benjaoming
Copy link
Contributor

This would have to be updated since we have new SASS for breadcrumbs since #1073. I did kind of like this separate file, since #1073 was one of the few PRs that didn't have a merge conflict to resolve in _theme_layout.sass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants