-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update to font awesome 5 #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: blendify/icons
Are you sure you want to change the base?
Update to font awesome 5 #1064
Conversation
This is still a work in progress, I am havign issues getting the font coppied over
| "build": "webpack --config webpack.prod.js", | ||
| "preinstall": "bin/preinstall.js" | ||
| }, | ||
| "dependencies": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm doesnt seem to like this being left blank, it got removed automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay! we may hold-off merging this to plan for a 0.6.0 release
|
I was having a hard time getting this to work without having to set the font face for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to block on renaming the fas class on this PR. I think we should figure out how to reuse fa class here, to avoid another breaking change for downstream packages.
| +font-face(FontAwesome, '#{$fa-font-path}/fa-solid-900') | ||
|
|
||
| .fa:before | ||
| .fas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to keep this fa or this is a breaking change as well. Downstream projects could be relying on fa classes and the rename seems easy enough to avoid
|
Fork Awesome activity seems have stalled since October, but something to consider: @agjohnson I don't know how feasible using |
|
Yeah I don't think trying to keep the use of I also don't think using a fork of fa is a good idea either, this will only add headaches when the fork is no longer maintained which seems to already be the case. |
|
There are font awesome 4 shims available for font awesome solid. This would be the best intermediate step without cutting a backwards incompatible release. If we keep the font awesome solid prefix, this is a strong breaking change for downstream users and we're likely already then talking about a v2.0 release with this change. v1.0 is shaping up to be dropping Sphinx <1.6 support. |
|
I still feel that this is an easy backwards incompatible change to avoid and that we should add the FA4 class naming to provide some small amount of insurance here. The end user can always customize on top of our theme, and could be expecting these classes that the theme has been providing. It will be difficult to catch this or warn the user about this, so I lean towards avoiding this scenario, especially with the number of points of backwards incompatibility that we already have. This only requires defining the additional class name to set the font-family and font-weight. Here's an example of defining the classes manually: I'll include this in a later milestone for now. |
This is still a work in progress