Skip to content

Fix margins between <dt> and <dl> #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

Fix margins between <dt> and <dl> #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sphinx_rtd_theme/static/css/theme.css
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions src/sass/_theme_rst.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,13 +486,17 @@
margin-bottom: $base-line-height
dt
font-weight: bold
margin-bottom: $base-line-height / 2
margin-bottom: ($base-line-height / 8)
// Most of the content within these dls are one liners, so I halve the normal margins.
p, table, ul, ol
margin-bottom: $base-line-height / 2
// rST seems to want dds to be treated as the browser would, indented.
dd
margin: 0 0 ($base-line-height / 2) $base-line-height
// The 20px are hard-coded to match the typical width of an emoji
// that is often used as prefix in definition lists.
// Previous value was "$base-line-height" which is not related to indenting
// This is a popular pattern here: https://docs.readthedocs.io/
margin: 0 0 ($base-line-height / 2) 20px
line-height: $base-line-height
> p:last-child,
> ol:last-child,
Expand Down