Fix code-block linenumbers highlight on Safari #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
Aug 31, 2023
Co-authored-by: Anthony <[email protected]>
|
Sounds good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using Safari and highlighting text in a code block with line numbers, the line numbers are also included. Line numbers are not included with eg. Firefox.
How to reproduce
Open https://sphinx-rtd-theme.readthedocs.io/en/stable/demo/demo.html#emphasized-lines-with-line-numbers with Safari (I used v16.5.2) and highlight the code block.
Expected behavior
Line numbers should not be included when highlighting.
What is done
-webkit-user-select: nonefield. This is needed on Safari to disable highlighting. See https://developer.mozilla.org/en-US/docs/Web/CSS/user-select for details.