theme.js: fix sidebar link finding code#1669
Open
ffplexim wants to merge 2 commits intoreadthedocs:masterfrom
Open
theme.js: fix sidebar link finding code#1669ffplexim wants to merge 2 commits intoreadthedocs:masterfrom
ffplexim wants to merge 2 commits intoreadthedocs:masterfrom
Conversation
Author
Author
|
Example of this bug occurring:
CC @oraNod |
|
@humitos @geographika is it possible to get this reviewed? Thanks :) |
|
Ping @agjohnson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the current section is not highlighted in the navigation sidebar if the current page's hash does not match the "primary anchor" (usually extracted from the section's title). For example, if the page's RST source has
and you link to it with
:ref:`foo`, "Bar" will not get selected in the sidebar.This is because the code for selecting the current section in the sidebar is still assuming that section elements are of the form
<div class="section">, instead of<section>. (docutils' HTML5 writer has been emitting the latter since docutils 0.17.)