Skip to content

Style headerlinks for table captions properly #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2017
Merged

Style headerlinks for table captions properly #454

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c8bc25
Style headerlinks for table captions properly
mitya57 Aug 20, 2017
1043272
Make .headerlink code work with center-aligned elements
mitya57 Sep 29, 2017
5b9861d
Lowered font size for table headerlink as requested in the review
mitya57 Dec 13, 2017
47e452a
Merge branch 'master' into master
Blendify Dec 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sass/_theme_rst.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,19 +108,19 @@
@extend h2

// This is the #href that shows up on hover. Sphinx's is terrible so I hack it away.
h1, h2, h3, h4, h5, h6, dl dt, p.caption
h1, h2, h3, h4, h5, h6, dl dt, p.caption, table > caption
.headerlink
display: none
visibility: hidden
font-size: 14px
@extend .fa
&:after
visibility: visible
content: "\f0c1"
font-family: FontAwesome
display: inline-block
&:hover .headerlink
display: inline-block
&:hover .headerlink:after
visibility: visible

Copy link
Contributor

@jessetan jessetan Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I think slightly reducing the link for table captions looks nicer, by adding:

  table > caption .headerlink:after
    font-size: 12px

Current PR:
14px

With font-size: 12px:
12px

Copy link
Contributor Author

@mitya57 mitya57 Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

table > caption .headerlink:after
font-size: 12px

.centered
text-align: center
Expand Down