Add Sidebar to Blockquotes #976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t sidebar of a quote as seen both on github and gmail quotes, as well as popularized in many forums. Without it, it is not clear that it is a quote at all.
|
These changes should be somewhere in https://github.com/readthedocs/sphinx_rtd_theme/tree/master/src/sass |
stsewd
added
Design
|
Closing as duplicate of #390 thanks for the PR anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sidebar of a quote, as seen both on github and gmail quotes, is a vertical line extending across multiple lines to indicate to the reader that they are reading text that is quoted from elsewhere. This has been popularized in many forums and clients, but is missing on RTD by default, making it unclear that a blockquote in the document is a quoted text.
The relevant part of the diff with linebreaks is:
.rst-content blockquote{ + padding-left:10px; + border-left:2px solid #9b9b9b; + margin-left:14px; - margin-left:24px; line-height:24px; margin-bottom:24px }The color chosen is the same as the main sidebar default color, while preserving the overall spacing width of the quote layout.
I am opening this as a draft PR as it is not the correct way to apply this change according to the contribution guidelines, but may provide inspiration to someone else to make a correct change using SASS and Wyrim.