Skip to content

Conversation

@agjohnson
Copy link
Contributor

So far, each page we've made has a special template. Eventually, pages
will share templates though, so hardcoding this won't be as useful. This
automates <body id="page-home"> using page.slug for now.

So far, each page we've made has a special template. Eventually, pages
will share templates though, so hardcoding this won't be as useful. This
automates `<body id="page-home">` using `page.slug` for now.
@agjohnson agjohnson mentioned this pull request Jan 26, 2022
@nienn
Copy link
Contributor

nienn commented Jan 27, 2022

The changes to the .md file are already being done in #27. Only in that case I remove the title because I prefer to see the clean site tile when at home rather than "Home - Read the Docs". This brings back the argument of using the tile slug instead of a variable separated from the title, but that's probably a separate discussion.

Other than the .md file, this looks good. Should we push it forward now or after the 4 pages are merged?

@agjohnson
Copy link
Contributor Author

Not needed anymore. This was mostly for CSS targeting, but we're back to native SUI for components and I haven't found the need for per-page selectors.

@agjohnson agjohnson closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants