Skip to content

Conversation

scottrhoyt
Copy link
Contributor

@scottrhoyt scottrhoyt commented Jun 14, 2025

SwiftSyntax 601.0.0 is missing the marker module SwiftSyntax601, meaning that it'll break builds (primarily macro modules) that support large version ranges of SwfitSyntax via #canImport(SwiftSyntax601) directives. This has been fixed in 601.0.1, but SwiftLint via SPM will keep the graph pinned against the broken 601.0.0 (like here). The only change of note from 601.0.0 -> 601.0.1 was adding the missing marker module, so this should be an easy fix on the SwiftLint side.

This also unlocks SwiftLint and dependent modules being able to use the preview for prebuilts in SPM for SwiftSyntax, which knocks a significant chunk off of compile time.

@SwiftLintBot
Copy link

SwiftLintBot commented Jun 14, 2025

18 Messages
📖 Building this branch resulted in the same binary size as when built on main.
📖 Linting Aerial with this PR took 1.59 s vs 1.02 s on main (55% slower).
📖 Linting Alamofire with this PR took 1.37 s vs 1.38 s on main (0% faster).
📖 Linting Brave with this PR took 9.54 s vs 9.55 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 24.11 s vs 24.2 s on main (0% faster).
📖 Linting Firefox with this PR took 11.56 s vs 11.58 s on main (0% faster).
📖 Linting Kickstarter with this PR took 10.78 s vs 10.77 s on main (0% slower).
📖 Linting Moya with this PR took 0.56 s vs 0.56 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 3.12 s vs 3.12 s on main (0% slower).
📖 Linting Nimble with this PR took 0.83 s vs 0.83 s on main (0% slower).
📖 Linting PocketCasts with this PR took 9.05 s vs 8.98 s on main (0% slower).
📖 Linting Quick with this PR took 0.48 s vs 0.48 s on main (0% slower).
📖 Linting Realm with this PR took 4.77 s vs 4.77 s on main (0% slower).
📖 Linting Sourcery with this PR took 2.43 s vs 2.44 s on main (0% faster).
📖 Linting Swift with this PR took 5.53 s vs 5.54 s on main (0% faster).
📖 Linting VLC with this PR took 1.45 s vs 1.45 s on main (0% slower).
📖 Linting Wire with this PR took 21.65 s vs 21.62 s on main (0% slower).
📖 Linting WordPress with this PR took 12.62 s vs 12.62 s on main (0% slower).

Generated by 🚫 Danger

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I only updated the Bazel dependency likewise and rebased to resolve the build issues.

@SimplyDanny SimplyDanny enabled auto-merge (squash) June 15, 2025 17:11
@SimplyDanny SimplyDanny merged commit 348800b into realm:main Jun 15, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants