Skip to content

Add multiline_call_arguments rule #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add multiline_call_arguments rule #6223

wants to merge 5 commits into from
+811 −265

Conversation

@GandaLF2006
Copy link
Contributor

@GandaLF2006 GandaLF2006 commented Sep 2, 2025 •
edited
Loading

Summary

This PR adds a new opt-in SwiftSyntax rule: multiline_call_arguments .

The rule mirrors the behavior of multiline_parameters for declarations, but applies it to function and method call sites (including Type.foo(...) / Enum.foo(...)), enforcing a consistent multiline formatting style for arguments.

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from b6407d6 to ea7f21b Compare September 2, 2025 15:35
@SwiftLintBot
Copy link

SwiftLintBot commented Sep 2, 2025 •
edited
Loading

3078 Warnings
⚠️ Big PR
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:45:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:50:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:83:32: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:152:21: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:222:21: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:266:21: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:302:21: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:179:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:179:24: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/FileHelpers.swift:16:21: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/ClockLayer.swift:78:40: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/BatteryIconLayer.swift:76:28: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:65:34: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:93:34: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:253:27: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ForecastLayer.swift:352:27: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:637:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:641:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:644:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in Alamofire: /Tests/TestHelpers.swift:450:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/Shared/ActionMessageView.swift:182:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/TabInstrumentation.swift:54:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/TabInstrumentation.swift:65:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/Instruments.swift:46:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/Instruments.swift:59:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/UIViewExtension.swift:30:23: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/UIViewExtension.swift:37:23: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/StatisticsLoader.swift:147:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/BookmarksCachingSearch.swift:106:34: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/Core/PrivacyFeatures.swift:66:38: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewControllerMenuBuilderExtension.swift:676:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BookmarksViewController.swift:140:51: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/UIHostingControllerExtension.swift:47:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AlertPlaygroundView.swift:113:25: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/FeatureFlagsDebugSettings/ExperimentCohortView.swift:48:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+MultiSelect.swift:91:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/PrivacyIconView.swift:146:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/SettingsViewModel.swift:1294:28: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/OnboardingIntro/OnboardingView+IntroDialogContent.swift:81:25: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingExperiment/OnboardingIntro/OnboardingIntroViewModel.swift:109:36: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AppServices/ReportingService.swift:252:33: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:607:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:780:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2603:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2617:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:2647:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewController.swift:3489:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BrowsingMenu/BrowsingMenuAnimator.swift:109:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/InternalUserCommands.swift:55:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabViewCell.swift:305:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:27:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:30:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:33:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:35:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:38:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:41:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:43:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:46:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:48:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/TabSwitcherViewController+KeyCommands.swift:51:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AutofillLoginDetailsViewController.swift:179:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AutofillLoginDetailsViewController.swift:183:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DebugScreensViewController.swift:86:21: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DebugScreensViewController.swift:104:21: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/BookmarksDebugViewController.swift:44:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:714:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:716:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:718:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:814:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:921:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:2081:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController.swift:3291:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/AsyncHeadlessWebview/HeadlessWebView.swift:72:16: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/Views/SubscriptionAIChatView.swift:42:21: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/DefaultOmniBarViewController.swift:215:32: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/OnboardingViewController.swift:178:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AIChat/AIChatViewControllerManager.swift:108:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AIChat/AIChatViewControllerManager.swift:130:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AIChat/AIChatViewControllerManager.swift:174:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AIChat/AIChatViewControllerManager.swift:179:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AIChat/AIChatViewControllerManager.swift:198:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AIChat/AIChatViewControllerManager.swift:202:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AIChat/AIChatViewControllerManager.swift:219:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/AIChat/AIChatViewControllerManager.swift:245:9: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/Views/SubscriptionSettingsView.swift:527:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/Subscription/Views/SubscriptionSettingsView.swift:787:72: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/IntervalSlider.swift:52:28: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CrashDebugScreen.swift:28:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CrashDebugScreen.swift:32:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CrashDebugScreen.swift:39:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CrashDebugScreen.swift:44:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CrashDebugScreen.swift:48:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CrashDebugScreen.swift:52:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/CrashDebugScreen.swift:59:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:27:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:38:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:40:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:42:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:44:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:46:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:48:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:50:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:52:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:54:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:56:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:58:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:66:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:68:17: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:82:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:84:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:86:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:88:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:90:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:92:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:94:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:96:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:98:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:100:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ This PR introduced a violation in DuckDuckGo: /iOS/DuckDuckGo/MainViewController+KeyCommands.swift:102:13: Warning: Arguments in function and method calls should be either on the same line or one per line when the call spans multiple lines (multiline_call_arguments)
⚠️ Danger found 3078 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 120.
18 Messages
📖 Building this branch resulted in a binary size of 26822.98 KiB vs 26775.45 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.73 s vs 0.75 s on main (2% faster).
📖 Linting Alamofire with this PR took 1.02 s vs 1.0 s on main (2% slower).
📖 Linting Brave with this PR took 6.81 s vs 6.83 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 21.81 s vs 21.77 s on main (0% slower).
📖 Linting Firefox with this PR took 10.87 s vs 10.83 s on main (0% slower).
📖 Linting Kickstarter with this PR took 7.52 s vs 7.47 s on main (0% slower).
📖 Linting Moya with this PR took 0.44 s vs 0.41 s on main (7% slower).
📖 Linting NetNewsWire with this PR took 2.22 s vs 2.23 s on main (0% faster).
📖 Linting Nimble with this PR took 0.62 s vs 0.66 s on main (6% faster).
📖 Linting PocketCasts with this PR took 6.99 s vs 7.24 s on main (3% faster).
📖 Linting Quick with this PR took 0.38 s vs 0.4 s on main (5% faster).
📖 Linting Realm with this PR took 3.24 s vs 3.22 s on main (0% slower).
📖 Linting Sourcery with this PR took 1.78 s vs 1.81 s on main (1% faster).
📖 Linting Swift with this PR took 4.16 s vs 4.15 s on main (0% slower).
📖 Linting VLC with this PR took 1.06 s vs 1.1 s on main (3% faster).
📖 Linting Wire with this PR took 17.37 s vs 17.33 s on main (0% slower).
📖 Linting WordPress with this PR took 11.32 s vs 11.26 s on main (0% slower).

Generated by 🚫 Danger

@GandaLF2006
Copy link
Contributor Author

GandaLF2006 commented Sep 2, 2025

@SimplyDanny One more PR for review :)

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from ea7f21b to 6210ddd Compare September 2, 2025 22:45
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch 2 times, most recently from 7e8d39b to 9672d83 Compare September 16, 2025 05:56
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from 9672d83 to 3a4497d Compare September 28, 2025 15:28
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from 3a4497d to 20ea825 Compare October 14, 2025 19:46
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from 20ea825 to a715d6c Compare November 15, 2025 08:17
@SimplyDanny
Copy link
Collaborator

SimplyDanny commented Nov 15, 2025

Thanks @GandaLF2006 and sorry for the late response!

I think this should a separate rule instead of an option, though.

@GandaLF2006
Copy link
Contributor Author

GandaLF2006 commented Nov 15, 2025

I think this should a separate rule instead of an option, though.

Hey. Are you sure about it? function_name_whitespace created as separate rule, but later merged with operator_whitespace here

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from a715d6c to ae9bb25 Compare November 15, 2025 17:28
@SimplyDanny
Copy link
Collaborator

SimplyDanny commented Nov 15, 2025

I think this should a separate rule instead of an option, though.

Hey. Are you sure about it? function_name_whitespace created as separate rule, but later merged with operator_whitespace here

Yes. Those rules were basically the same. The only difference was the function name being a real name vs. a symbol.

Here, we are talking about function declarations vs. function calls. That's totally different syntax elements even though the idea is the same. We might come up with different options for declarations and calls, which we can't separate when both are mixed in the same rule.

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from ae9bb25 to e17d184 Compare November 21, 2025 13:49
@GandaLF2006 GandaLF2006 changed the title multiline_parameters: check function call arguments (optional via check_calls) Add multiline_parameters_on_call rule Nov 21, 2025
@rgoldberg
Copy link

rgoldberg commented Nov 21, 2025 •
edited
Loading

Should this possibly be renamed multiline_arguments, multiline_call_arguments, or multiline_call_parameters?

I'd recommend one of the first two, since it's for arguments being passed to parameters, not just the parameters themselves.

Also, the greater the naming difference between the two rules, the less likely people are to mistake them for each other.

If you still want to use parameters, multiline_call_parameters is more concise than multiline_parameters_on_call.

If you really want the new rule to start with the whole name as ``multiline_parameters, maybe multiline_parameters_for_call` sounds better.

@GandaLF2006
Copy link
Contributor Author

GandaLF2006 commented Nov 21, 2025

@rgoldberg Good catch.
Renamed to multiline_call_arguments

@GandaLF2006
Copy link
Contributor Author

GandaLF2006 commented Nov 21, 2025

@SimplyDanny It's done! Please review :)

@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from e17d184 to c86e8b2 Compare November 21, 2025 16:27
@GandaLF2006 GandaLF2006 changed the title Add multiline_parameters_on_call rule Add multiline_call_arguments rule Nov 21, 2025
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch 3 times, most recently from 132c344 to e1dfb74 Compare November 21, 2025 21:32
@GandaLF2006 GandaLF2006 force-pushed the gandalf2006/check_calls_multiline_parameters branch from 4e534d8 to af2eb10 Compare November 26, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GandaLF2006 @SwiftLintBot @SimplyDanny @rgoldberg